Update the signature of dba_open() and dba_popen() #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 27, 2021
Comment on lines
+14
to
+16
| <methodparam choice="opt"><type class="union"><type>string</type><type>null</type></type><parameter>handler</parameter><initializer>&null;</initializer></methodparam> | ||
| <methodparam choice="opt"><type>int</type><parameter>permission</parameter><initializer>0644</initializer></methodparam> | ||
| <methodparam choice="opt"><type>int</type><parameter>map_size</parameter><initializer>0</initializer></methodparam> |
There was a problem hiding this comment.
Probably should have a note that named arguments do not work, as this signature is only the case since PHP 8.2 IIRC when I landed the changes
|
Ahh, yes, I've just checked it, and this change is specific to PHP 8.2, so I'll wait with this PR until this version is ready to be documented |
|
@kocsismate can you update this PR now that we are closer to release? :) |
Co-authored-by: George Peter Banyard <[email protected]>
|
Please feel free to suggest better wording :) |
Girgias
reviewed
Nov 7, 2022
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
Co-authored-by: George Peter Banyard <[email protected]>
|
Thank you! |
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
Co-authored-by: George Peter Banyard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.