Skip to content

Add missing reflinks to changelog #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

glensc
Copy link

@glensc glensc commented Mar 31, 2021

@glensc
Copy link
Author

glensc commented Mar 31, 2021

A side topic, what you think of converting all links to reflinks? makes the file much easier to read in the editor and plain text viewer:

-- Restore php 5.3 support [#51](https://github.com/php-parallel-lint/PHP-Parallel-Lint/pull/51) from [@glensc](https://github.com/glensc).
+- Restore php 5.3 support [#51] from [@glensc].
+
+[#51]: https://github.com/php-parallel-lint/PHP-Parallel-Lint/pull/51
+[@glensc]: https://github.com/glensc

bonus is that GitHub handles need to be declared only once, not for each ocurrence.

@glensc glensc mentioned this pull request Apr 5, 2021
@grogy
Copy link
Member

grogy commented Apr 7, 2021

Thank you @glensc for the fix. I will merge it.

Converting reflinks - nice, it is better. Writing in the current style is uncomfortable. Know you some tools for converting?

@grogy grogy merged commit 2aee0ad into php-parallel-lint:master Apr 7, 2021
@glensc glensc deleted the patch-1 branch April 7, 2021 19:59
@glensc
Copy link
Author

glensc commented Apr 7, 2021

I tried to use some tools, but none of them did the right thing fully, so ended up reformatting manually anyway:

tried:

  • pandoc --from markdown --to markdown --wrap=preserve --reference-links
  • npx markdownlint
  • npx markdownlint-cli2
  • npx markdownlint-cli
  • npx prettier
  • npx remark README.md -o --use reference-links
  • npx remark CHANGELOG.md -o --use defsplit
  • good old vim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants