Skip to content

Move to supporting Box v3 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mwgamble
Copy link

@mwgamble mwgamble commented Sep 1, 2020

Box v2 has been out of support for a very long time.

Fixes #36

Box v2 has been out of support for a very long time.
@mwgamble
Copy link
Author

mwgamble commented Sep 1, 2020

Is it really still necessary to support PHP 5.4? It's been end-of-life for a long time now.

@jrfnl
Copy link
Collaborator

jrfnl commented Sep 1, 2020

Is it really still necessary to support PHP 5.4? It's been end-of-life for a long time now.

As this is a linting tool which is used in the CI/QA toolset for other projects, supporting a wide range of PHP versions, IMHO, is a good thing and something which makes this the tool of choice.

@mwgamble
Copy link
Author

mwgamble commented Sep 2, 2020

Fair enough. I'll push an update shortly that removes the use of ::class.

@mwgamble
Copy link
Author

mwgamble commented Sep 4, 2020

The issue with the PHP 5.4 CI run seems unrelated to my changes. I'm not sure how to proceed.

@mfn
Copy link

mfn commented Sep 4, 2020

The issue with the PHP 5.4 CI run seems unrelated to my changes. I'm not sure how to proceed.

I found birgire/geo-query#13 (review) , also the follow up comment seems insightful.

Seems due to missing support for some things, in PHP < 5.6 there's some manual TLS verification going on in composer not working out.

@grogy
Copy link
Member

grogy commented Sep 11, 2020

I tried it rebase to master and CI looks ok, via https://travis-ci.org/github/php-parallel-lint/PHP-Parallel-Lint/builds/726418723

@grogy
Copy link
Member

grogy commented Sep 11, 2020

Changes looks ok. Can you update readme, please? - https://github.com/php-parallel-lint/PHP-Parallel-Lint#create-phar-package

@grogy
Copy link
Member

grogy commented Dec 27, 2020

Ping @mwgamble :-)

@mwgamble
Copy link
Author

Apologies, I've changed jobs since I first put this together and haven't had a chance to look at it since then. I'll try to take a look over the weekend.

@deatharse
Copy link

@mwgamble Last box version I can build with (using PHP 7.3) is 3.5.0. Do you remember what version you used?

@grogy
Copy link
Member

grogy commented May 8, 2021

When you will rebase it please consider that we run phar build in Github Actions

@mwgamble
Copy link
Author

I'm sorry, I don't know when I'll be able to work on this again. I'm not really working with PHP at the moment and I don't have access to the repository I was working on. Someone else will need to take up the mantle.

@jrfnl jrfnl mentioned this pull request Dec 1, 2021
@grogy grogy closed this in #70 Dec 1, 2021
@grogy
Copy link
Member

grogy commented Dec 1, 2021

@mwgamble solve PR [#70] from @jrfnl Thank you for the example of solution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Make box config compatible with humbug/box
5 participants