-
Notifications
You must be signed in to change notification settings - Fork 23
Move to supporting Box v3 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Box v2 has been out of support for a very long time.
Is it really still necessary to support PHP 5.4? It's been end-of-life for a long time now. |
As this is a linting tool which is used in the CI/QA toolset for other projects, supporting a wide range of PHP versions, IMHO, is a good thing and something which makes this the tool of choice. |
Fair enough. I'll push an update shortly that removes the use of |
The issue with the PHP 5.4 CI run seems unrelated to my changes. I'm not sure how to proceed. |
I found birgire/geo-query#13 (review) , also the follow up comment seems insightful. Seems due to missing support for some things, in PHP < 5.6 there's some manual TLS verification going on in composer not working out. |
I tried it rebase to master and CI looks ok, via https://travis-ci.org/github/php-parallel-lint/PHP-Parallel-Lint/builds/726418723 |
Changes looks ok. Can you update readme, please? - https://github.com/php-parallel-lint/PHP-Parallel-Lint#create-phar-package |
Ping @mwgamble :-) |
Apologies, I've changed jobs since I first put this together and haven't had a chance to look at it since then. I'll try to take a look over the weekend. |
@mwgamble Last box version I can build with (using PHP 7.3) is 3.5.0. Do you remember what version you used? |
When you will rebase it please consider that we run phar build in Github Actions |
I'm sorry, I don't know when I'll be able to work on this again. I'm not really working with PHP at the moment and I don't have access to the repository I was working on. Someone else will need to take up the mantle. |
Box v2 has been out of support for a very long time.
Fixes #36