PMM-2726: Abort on timeout. #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvenil
force-pushed
the
PMM-2726_abort_on_timeout
branch
from
46d9637 to
4bd55cb
Compare
arvenil
force-pushed
the
PMM-2726_abort_on_timeout
branch
from
4bd55cb to
f48d09d
Compare
arvenil
force-pushed
the
PMM-2726_abort_on_timeout
branch
from
240a3a6 to
1a016b9
Compare
rnovikovP
approved these changes
Sep 10, 2018
|
Affected by go-sql-driver/mysql#858; we may need to disable global pool temporarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort data collection:
X-Prometheus-Scrape-Timeout-Seconds--timeout-offset. Default0.5second.Tested manually. Returns metrics even if scraping was canceled. Example errors:
Based on https://github.com/prometheus/blackbox_exporter/blob/master/main.go#L74-L83
Upstream PR: prometheus#323