Change var to const or let

[benhalverson]

Addresses #598

Summary of changes:
This is the start of converting var's to const or let.
Looking for some initial feedback

[raphaelokon]

LGTM. One thing worth doing would be adding http://eslint.org/docs/rules/prefer-const to the .eslintrc and rerun the the lint step. This way we would prevent accidentally adding var in future when merging PRs.

[bmuenzenmeyer]

Awesome work. Since this is so significant a change I am going to point it to dev-3.0

[bmuenzenmeyer]

@benhalverson
This is a great step in the right direction, thanks!
I merged this with dev-3.0 - all still runs. Turning on prefer-const as Raphael suggests yeilds 100+ errors. Are you willing to fix ?

[raphaelokon]

@bmuenzenmeyer Those lint errors are just guides and does not always reflect appropriateness – just a compass. Awesome job @benhalverson

[bmuenzenmeyer]

Sorry I was not articulate. If we turn prefer-const on permanently and do not address errors, future lint efforts are harder to parse through. I am likewise ecstatic with the work done so far.

…

On Sun, Feb 5, 2017, 2:00 PM Raphael Okon ***@***.***> wrote: @bmuenzenmeyer <https://github.com/bmuenzenmeyer> Those lint *errors* are just guides and does not always reflect appropriateness – just a compass. Awesome job @benhalverson <https://github.com/benhalverson> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#608 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASNw3AGU6jtXq11hC-q31fWyaOXI5xTks5rZip4gaJpZM4L3azU> .

[benhalverson]

Thanks Guys. Yes I can work on the rest. I was going to ask about changing the vars in the tests also. Should that be another issue?

[bmuenzenmeyer]

The tests are not linted due to their inconsistent style from years of development. I'd leave them out of scope for now and focus on the main library. If you want to do it as another issue, you are most welcome.

[benhalverson]

i didn't have these conflicts on my machine. @bmuenzenmeyer I'll see if I can resolve them.

[bmuenzenmeyer]

@benhalverson will fix this on my end tomorrow morning

[bmuenzenmeyer]

@benhalverson I am rolling this into #610 as I fought with it enough here and there today and I think it needs a bit more oomph.

[benhalverson]

Ok. Thanks

[bmuenzenmeyer]

With #610 done, I think this is in limbo. Please see my other comments.

[benhalverson]

@bmuenzenmeyer do I need to do anything here?

[bmuenzenmeyer]

@benhalverson mostly asking if you are okay with me closing. I had to merge it into work already apart of dev-3.0. The rub is for some reason I don't see any of your commits (meaning you won't get "credit" for the work).I think the circumstances of the merge somehow qualified all the commits as my own? This is the first time this has happened.

I will still display this PR and your name in the changelog and release notes, as you did great work!
Are you okay with that?

[benhalverson]

Yep it's ok with me