-
Notifications
You must be signed in to change notification settings - Fork 273
Use procedural macros #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move delegates to core - is this the right place
Removes need for Wrap* types
2de5df6
to
e303b0d
Compare
Now ready for full review @tomusdrw |
tomusdrw
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66.
Replaces the
build_rpc_trait!
macro with a trait level#[rpc]
attribute. e.g.and pubsub:
Example of converting parity-ethereum.
Tasks
jsonrpc-macros
, need to figure out where they should goTrailing
replace withOption
in last positionjsonrpc-macros
and make them workparity-ethereum
substrate
jsonrpc-macros
with proc macros implementation currently injsonrpc-derive
. Need to find out how best to deprecate the macro or the entire crate.crate
?)Future Improvements
protocol_version
->protocolVersion
, allow overrides as per serde.proc-macro-diagnostics
e.g. https://github.com/dtolnay/syn/blob/master/examples/lazy-static/lazy-static/src/lib.rs which is currently anightly
feature. Possible to bring it in already with ourt own `nightly' features with shims as per diesel