Skip to content

Associated types in RPC traits #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

gavofyork
Copy link
Member

No description provided.

@rphmeier
Copy link
Contributor

rphmeier commented Jun 2, 2018

The ASSOCIATED type is strange to me. For the use-cases where I need this, it would be better with regular generics.

@rphmeier rphmeier changed the title Forward types in macro Associated types in RPC traits Jun 5, 2018
@rphmeier
Copy link
Contributor

rphmeier commented Jun 5, 2018

I think by swapping the rules for traits with metadata and those without, we can get rid of the ASSOCIATED keyword in this and simply add an extra rule to each:

$(type $assoc_ty_name: ident; )*

in the metadata case, this would follow the type Metadata; declaration.

@tomusdrw
Copy link
Contributor

tomusdrw commented Jul 5, 2018

@gavofyork @rphmeier I believe it's not required any more in Polkadot, is it? Would be awesome to avoid ASSOCIATED keyword if possible, see #267 (comment)

@rphmeier
Copy link
Contributor

rphmeier commented Jul 6, 2018

@tomusdrw no, not needed for polkadot any more. 100% agree about ASSOCIATED keyword.

@tomusdrw
Copy link
Contributor

Closing, since I doesn't seem to be needed. We might consider this as part of #66

@tomusdrw tomusdrw closed this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants