API: Index.duplicated should return np.array #9112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -486,14 +487,15 @@ def searchsorted(self, key, side='left'): | |||
| @Appender(_shared_docs['drop_duplicates'] % _indexops_doc_kwargs) | |||
| def drop_duplicates(self, take_last=False, inplace=False): | |||
| duplicated = self.duplicated(take_last=take_last) | |||
| result = self[~(duplicated.values).astype(bool)] | |||
| values = getattr(duplicated, 'values', duplicated) | |||
There was a problem hiding this comment.
do you still need this -- can duplicated be an index here?
There was a problem hiding this comment.
This was intended for Series, but looks not required. Both modified.
| @@ -27,6 +27,8 @@ Backwards incompatible API changes | |||
|
|
|||
| .. _whatsnew_0160.api_breaking: | |||
|
|
|||
| - ``Index.duplicated`` now returns `np.array(dtype=bool)` rathar than `Index(dtype=object)` containing `bool` values. (:issue:`8875`) | |||
There was a problem hiding this comment.
Ah, thanks for correction and merge!
|
@sinhrks thanks! (I made the minor correction). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 2nd issue of #8875.
Index.duplicatedto returnnp.array.