Skip to content

API: add inplace keyword to Series.order/sort to make them inverses (GH6859) #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2014

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 10, 2014

closes #6859

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Apr 10, 2014

See Also
--------
Series.order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation here? Something like Series.order : equivalent method but not in-place by default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the same in the order docstring but then the inverse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jreback
Copy link
Contributor Author

jreback commented Apr 10, 2014

now to be even more confusing

DataFrame.sort(inplace=False) is the default (and returns a new Frame)

Series.sort(inplace=True)
Seires.order(inplace=False)

To fix this is REALLY breaking the API

maybe add DataFrame.order(inplace=False)

and FutureWarn that DataFrame.sort(inplace=False) should be using order?

jreback added a commit that referenced this pull request Apr 12, 2014
API: add inplace keyword to Series.order/sort to make them inverses (GH6859)
@jreback jreback merged commit 8161c85 into pandas-dev:master Apr 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: add inplace to Series.sort/order
2 participants