TST: Address matplotlib 3.10 deprecation of vert= #60584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
|
Merging to get a green CI |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 17, 2024
mroeschke
added a commit
that referenced
this pull request
Dec 18, 2024
…ecation of vert=) (#60586) * Backport PR #60584: TST: Address matplotlib 3.10 deprecation of vert= * Add missing import * Ignore pre-commit check --------- Co-authored-by: Matthew Roeschke <[email protected]>
Comment on lines
+1074
to
+1089
| @pytest.mark.xfail( | ||
| Version(mpl.__version__) >= Version("3.10"), | ||
| reason="Fails starting with matplotlib 3.10", | ||
| ) | ||
| def test_boxplot_vertical(self, hist_df): | ||
| df = hist_df | ||
| numeric_cols = df._get_numeric_data().columns | ||
| labels = [pprint_thing(c) for c in numeric_cols] | ||
|
|
||
| # if horizontal, yticklabels are rotated | ||
| ax = df.plot.box(rot=50, fontsize=8, vert=False) | ||
| kwargs = ( | ||
| {"vert": False} | ||
| if Version(mpl.__version__) < Version("3.10") | ||
| else {"orientation": "horizontal"} | ||
| ) | ||
| ax = df.plot.box(rot=50, fontsize=8, **kwargs) |
There was a problem hiding this comment.
Just to understand the change: even though using the new keyword for mpl >= 3.10, it is still failing somehow? (given you added the xfail)
There was a problem hiding this comment.
Yeah that's correct. It appears that changing this to use the equivalent, new matplotlib 3.10 keyword causes some tests to fail. I was unable to determine if the failure was on our side or the matplotlib side
|
Thanks for addressing this! |
KevsterAmp
pushed a commit
to KevsterAmp/pandas
that referenced
this pull request
Mar 12, 2025
* TST: Address matplotlib 3.10 deprecation of vert= * Type in ._version * Address other failures * more test faillures * Add more xfails * mypy error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. https://app.circleci.com/jobs/github/pandas-dev/pandas/243601