Skip to content

BUG: isin check incorrect with uint64 dtype #60120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SpoopyPillow
Copy link
Contributor

@SpoopyPillow
Copy link
Contributor Author

SpoopyPillow commented Oct 29, 2024

These test failures come from changing the np_find_common_type method, which the isin method uses to cast the values to a common type. The problem is that when taking a int64 and uint64, the common type is float64, causing precision errors. I instead had np_find_common_type return an object type, which fixed the issue for the bug but obviously caused a lot of test issues.

Should I only edit inside the isin method, or should I change the np_find_common_type? Any advice would be helpful.

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 29, 2024
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: isin check with numpy array works incorrectly when using UInt64 dtype
2 participants