BUG: Setting values on DataFrame with multi-index .loc(axis=0) access adds columns #58301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… axis argument if supplied to loc. added a test checking for this based on the github issue as well
mroeschke
reviewed
Apr 18, 2024
mroeschke
added
the
Indexing
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Apr 18, 2024
|
Thanks @eshaready |
|
Thanks @eshaready! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
… adds columns (pandas-dev#58301) * fixed the issue by making sure setting an item takes into account the axis argument if supplied to loc. added a test checking for this based on the github issue as well * Running pre commit checks * Pre commit checks * Update doc/source/whatsnew/v3.0.0.rst Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFramewith multi-index.loc(axis=0)access adds columns #58116doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Setting values on a Multi-Index DataFrame with axis=0 passed into loc caused columns to be added when they shouldn't be.
This occurred because when setting items(s) with loc, the axis argument was ignored; _ensure_listlike_indexer(self, key, axis=None, value=None) never has self.axis passed in, and always sets axis to 1.
To solve this, we passed self.axis in as an argument when calling the function, and added an if statement to only set axis to 1 if none is specified.
coauthored with @regieleki !