BUG: fix groupby.quantile inconsistency when interpolation='nearest'
#56926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 17, 2024
pandas/_libs/groupby.pyx
Outdated
| @@ -1286,7 +1286,7 @@ def group_quantile( | |||
| elif interp == INTERPOLATION_MIDPOINT: | |||
| out[i, k] = (val + next_val) / 2.0 | |||
| elif interp == INTERPOLATION_NEAREST: | |||
| if frac > .5 or (frac == .5 and q_val > .5): # Always OK? | |||
| if frac > .5 or (frac == .5 and idx % 2 == 1): # Always OK? | |||
There was a problem hiding this comment.
Could you replace # Always OK? with a short comment above what idx % 2 == 1 is for?
There was a problem hiding this comment.
I added a comment.
mroeschke
approved these changes
Jan 18, 2024
|
Thanks @yuanx749 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
pandas-dev#56926) * BUG: fix groupby.quantile inconsistency when interpolation='nearest' * add whatsnew * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the xfail mark in previous tests. Do we need to add more tests?
Under the hood,
np.quantileusesnp.roundfor nearest interpolation, which rounds to the even idx when exactly halfway.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.