datetime64 series and dataframe test GH#28273 #52217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liang3zy22
force-pushed
the
gh28273
branch
2 times, most recently
from
ade38fd to
6c29ec2
Compare
mroeschke
requested changes
Mar 27, 2023
| @@ -1221,6 +1221,12 @@ def test_dt64_mul_div_numeric_invalid(self, one, dt64_series, box_with_array): | |||
| with pytest.raises(TypeError, match=msg): | |||
| one / obj | |||
|
|
|||
| def test_dt64_series_dataframe(self): | |||
There was a problem hiding this comment.
I don't think this would hit the line of code explained in the issue, it would need to hit a json parsing path
mroeschke
added
Testing
Signed-off-by: Liang Yan <[email protected]>
|
I have tested the ujson.{decode,encode} with np.datetime64. I can't find a method to decode the result of encode to datetime64. So I compare the decode and encode result directly. |
|
Actually, turns out this code doesn't exist in the current code base so it no longer needs testing. Closing but thanks for attempting to add a test for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used main codes to verify the GH28273. Unlike the original codes, the series and data frame types are same. So my codes just test its current behavior.