-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
STYLE enable ruff TCH on pandas/core/arrays #51786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are there any updates with this PR? |
pandas/core/arrays/arrow/dtype.py
Outdated
elif ( | ||
pa.types.is_binary(pa_type) | ||
or pa.types.is_fixed_size_binary(pa_type) | ||
or pa.types.is_large_binary(pa_type) | ||
): | ||
elif pa.types.is_binary(pa_type): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've still got unrelated changes, please check through them
pandas/core/arrays/string_arrow.py
Outdated
from pandas._typing import ( | ||
Dtype, | ||
Scalar, | ||
npt, | ||
) | ||
|
||
# from pandas._typing import ( | ||
# Dtype, | ||
# Scalar, | ||
# npt, | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look right
thanks for the feedback, really appreciate it!
can you run |
can you run |
Working on it now |
For some reason I'm getting |
It worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.