-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TYP: added missing __init__ in pandas/core/methods #51052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are some new errors detected - will try to address or ignore them. |
@@ -135,7 +135,7 @@ repos: | |||
types: [python] | |||
stages: [manual] | |||
additional_dependencies: &pyright_dependencies | |||
- [email protected].276 | |||
- [email protected].284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more errors with 1.1.291 microsoft/pyright#4546
The second commit fixes type issues uncovered by a newer pyright version. The third commit uses Sequence[Hashable] more consistently. |
Looks good just a merge conflict |
Rebased and green |
Thanks @twoertwein |
See microsoft/pyright#4544 (comment)
Ruff's INP001 could have caught this. Could enable it if the following are ignored: