BUG: JSON serialization with orient split fails roundtrip with MultiIndex #50904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 23, 2023
| @@ -0,0 +1,19 @@ | |||
| { | |||
mroeschke
reviewed
Jan 23, 2023
| @@ -0,0 +1,3 @@ | |||
| import pandas | |||
There was a problem hiding this comment.
This should not be commited either
datapythonista
changed the title
There was a problem hiding this comment.
Thanks @labibdotc for the PR. Besides addressing the comments when you've got the time, can you also merge main into your branch and fix the conflicts. You may want to add your release note not at the very end of the list. That should help prevent conflicts.
| marks=pytest.mark.xfail( | ||
| reason="Produces JSON but not in a consistent manner" | ||
| ), | ||
| ), |
There was a problem hiding this comment.
This is not the test, the test is test_roundtrip_multiindex and what needs to be removed is the xfail decorator.
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.0.0.rst