-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH/API: preserve non-nano in to_datetime #50369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1992db1
ENH/API: preserve non-nano in to_datetime
jbrockmendel 06caddf
GH ref
jbrockmendel 77f4719
Merge branch 'main' into ref-to_datetime-2
jbrockmendel 79565d7
Fix PandasArray case
jbrockmendel 8c25a4c
Merge branch 'main' into ref-to_datetime-2
jbrockmendel f2c3eff
mypy fixup
jbrockmendel e72a9e1
Merge branch 'main' into ref-to_datetime-2
jbrockmendel 52c383c
comment about errors=ignore
jbrockmendel fd569e1
Merge branch 'main' into ref-to_datetime-2
jbrockmendel 54b58d9
Merge branch 'main' into ref-to_datetime-2
jbrockmendel aff3444
Merge branch 'main' into ref-to_datetime-2
jbrockmendel 87f154b
Merge branch 'main' into ref-to_datetime-2
jbrockmendel dd8b4c8
suggested edits
jbrockmendel 50e8a3e
Merge branch 'main' into ref-to_datetime-2
jbrockmendel 7fb0fa7
Merge branch 'main' into ref-to_datetime-2
jbrockmendel b149de1
Merge branch 'main' into ref-to_datetime-2
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any test that would hit the
else
branch? I think nowis_datetime64_dtype(bins)
is alwaysTrue
in the test suiteThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no extant test, but im not sure its impossible to reach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps raise an AssertionError in the
else
block? the it won't show up as uncoveredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not concerned about it showing as uncovered, and don't want to break potentially-working code in the wild.
will need to revisit this eventually to handle non-nano without the cast anyway