TST: catch some test warnings #48031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Aug 11, 2022
mroeschke
added
Testing
|
Thanks @jbrockmendel (npdev build only raises on DeprecationWarning not FutureWarning) |
Has it always been like this? I thought we checked that we checked for FutureWarnings to make sure we weren't issuing any accidentally (e.g. ATM we issue some in fillna that we shouldn't bc we are using deprecated usage) |
|
Ah looks like I made the filter more narrow because numpy was propagating a distutils warning too? #46767 |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a hundred and change warnings locally when I run the test suite, am surprised the npdev build isn't failing on these. This gets a handful of them.