ENH: Timestamp +- timedeltalike scalar support non-nano #47313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
reviewed
Jun 13, 2022
| @@ -390,20 +387,31 @@ cdef class _Timestamp(ABCTimestamp): | |||
| # TODO: no tests get here | |||
| other = ensure_td64ns(other) | |||
|
|
|||
| # TODO: what to do with mismatched resos? | |||
There was a problem hiding this comment.
IMO I would raise and only allow this for matching resos
mroeschke
reviewed
Jun 13, 2022
| @@ -853,6 +853,29 @@ def test_to_period(self, dt64, ts): | |||
| alt = Timestamp(dt64) | |||
| assert ts.to_period("D") == alt.to_period("D") | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "td", [timedelta(days=4), Timedelta(days=4), np.timedelta64(4, "D")] | |||
There was a problem hiding this comment.
So in the future Timedelta with a non-nano reso will be tested separately to solidify ts._reso/td._reso semantics?
There was a problem hiding this comment.
thats the idea, yes
mroeschke
added
Datetime
mroeschke
approved these changes
Jun 13, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…7313) * ENH: Timestamp +- timedeltalike scalar support non-nano * catch and re-raise OverflowError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.