-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Change numeric_only default to True #46096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 23 commits into
pandas-dev:main
from
NumberPiOso:ench-quantile-numeric-only
Mar 18, 2022
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d98e262
BUG: Change numeric_only default to True
NumberPiOso 0db8e52
Add future warning numeric_only in DataFrame.quantile
NumberPiOso c427795
Add deprecations.quantile_datetime_timedelta_colums in whatsnew
NumberPiOso fcf37a8
Add stacklevel to warning in DataFrame.quantile
NumberPiOso 7e1d286
Modify test to expect warning in test_quantile.py
NumberPiOso a5e6def
Ignore FutureWarning at test_quantile.py
NumberPiOso 108bb45
Correct documentation numeric_only inDataFrame.quantile
NumberPiOso 93c5f65
DEPR: Specify nodefault for numeric_only default
NumberPiOso 0f37c30
DEPR: Update whatsnew #7308
NumberPiOso a324dc9
DEPR: Correct frame.quantile tests to specify numeric_only
NumberPiOso 82db984
DEPR: Correct message error frame.quantile
NumberPiOso 9e9b7a9
DEPR: Remove warning filtering DataFrame.quantile
NumberPiOso 67f2cfa
DEPR: Update whatsnew doc about numeric_only attribute
NumberPiOso 42e7df4
DEPR: Update Examples in docs frame.quantile
NumberPiOso d0a1221
DEPR: Correct test finalize DataFrame.quantile
NumberPiOso 377cc54
Revert "DEPR: Correct frame.quantile tests to specify numeric_only"
NumberPiOso b460aa2
DEPR: Update tests of quantile with non num cols"
NumberPiOso 7194d13
DEPR: Raise warning frame.quantile with numeric_only
NumberPiOso f5f7a3e
DEPR: Update doctests quantile, numeric only
NumberPiOso 16e5fc2
DEPR: Correct test_numeric_only_default_false_warning
NumberPiOso b88b196
DEPR: Add non numeric test to numeric_only warning
NumberPiOso db68bf2
DERP: correct_test_produces_warning in frame.quantile
NumberPiOso 4438118
Merge remote-tracking branch 'upstream/main' into ench-quantile-numer…
NumberPiOso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you testing with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual quantile method must ignore the non numeric columns and produce a warning. I am using three different non-numeric columns. A date column, a string column and a column of objects.