Adding unixtime property to Timestamp and DatetimeIndex #45217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 6, 2022
pandas/_libs/tslibs/timestamps.pyx
Outdated
| @@ -871,7 +886,13 @@ cdef class _Timestamp(ABCTimestamp): | |||
| """ | |||
| # GH 17329 | |||
| # Note: Naive timestamps will not match datetime.stdlib | |||
| return round(self.value / 1e9, 6) | |||
| warnings.warn( | |||
There was a problem hiding this comment.
this is a stdlib method and should remain
jreback
requested changes
Jan 8, 2022
| """ | ||
| # GH 17329 | ||
| # Note: Naive timestamps will not match datetime.stdlib | ||
| return round(self.value / 1e9, 6) |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
closing as stale. we would still take this if rebased & updated. pls ping to reopen if interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #43975 (#43975), adding a unixtime property to Timestamp and Datetime index.
In the course of developing this PR, I discovered that the Timestamp class already has a method called timestamp() which calculates a unixtime. I deprecated the timestamp method, as I found the name ambiguous (there's nothing about the phrase timestamp that leads me to think of unixtimes).
This is my first PR against pandas, so apologies for any violations of conventions for code or PRs.