44414 data frame attributes not propagating with astype #44680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skwirskj
commented
Nov 30, 2021
•
skwirskj
commented
- closes BUG: DataFrame attributes are lost after specifying dtype for select columns #44414
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Added a finalize call so that the metadata, specifically attributes, is retained when the datatype of one column is changed.
Passed previous DataFrame to finalize to ensure the correct attributes are being passed to the new DataFrame. Also added a test to test that calling astype passes attributes to the new DataFrame.
phofl
requested changes
Nov 30, 2021
|
Couple of comments |
Changed description of bug fix to better explain what is being changed. Added more explicit varibale names in astype test to demonstrate the result and expected values.
38 tasks
jreback
requested changes
Dec 2, 2021
jreback
requested changes
Dec 5, 2021
| @@ -714,6 +714,19 @@ def test_astype_noncontiguous(self, index_slice): | |||
| expected = df.iloc[index_slice] | |||
| tm.assert_frame_equal(result, expected, check_dtype=False) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "dtype", ["float", "int32", "int64", "string", "int16", "float32"] | |||
There was a problem hiding this comment.
can you use one of the fixtures in pandas/conftest.py instead
Added fixture use in both test_astype_retain_attrs functions in the DataFrame and Series testing files.
jreback
approved these changes
Dec 5, 2021
|
thanks @skwirskj |
|
No problem @jreback thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.