Skip to content

CLN: no need for suffices anymore in test_hashtable.py #44034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

CLN: no need for suffices anymore in test_hashtable.py #44034

merged 1 commit into from
Oct 15, 2021

Conversation

realead
Copy link
Contributor

@realead realead commented Oct 14, 2021

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Since we have version with fused types, there is no need to call precise version (i.e. with suffices like int64, int32 and so on) any longer.

@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Oct 14, 2021
@alimcmaster1 alimcmaster1 added Testing pandas testing functions or related to the test suite Clean labels Oct 14, 2021
alimcmaster1
alimcmaster1 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM

@mroeschke mroeschke merged commit dca6901 into pandas-dev:master Oct 15, 2021
@mroeschke
Copy link
Member

Thanks @realead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@realead @mroeschke @alimcmaster1