Test that using a tuple or list for parameter ascending of sort_index is the same
#43963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l to using a 'list'
phofl
reviewed
Oct 11, 2021
| df.set_index(["class", "animal"], inplace=True) | ||
|
|
||
| sorted1 = df.sort_index(level=(0, 1), ascending=[True, False]) | ||
| sorted2 = df.sort_index(level=(0, 1), ascending=(True, False)) |
There was a problem hiding this comment.
Please define index directly without set_index and define expected explicitly. Also parametrize over list and tuple. Please call sorted1 or sorted2 result
There was a problem hiding this comment.
@phofl Thank you, please let me know if I addressed all the changes you requested in my last commit.
jreback
added
Reshaping
jreback
reviewed
Oct 13, 2021
| @@ -785,6 +785,48 @@ def test_sort_index_use_inf_as_na(self): | |||
| result = expected.sort_index() | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| "ascending", | |||
| [(True, False)], | |||
There was a problem hiding this comment.
can you add another parameterization as a list also
|
thanks @fAndreuzzi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find a suitable place to add a
whatsnewentry, if there is one I will push another commit.