Skip to content

DEPR: Index inferring numeric dtype from ndarray[object] #42870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2021
Merged

DEPR: Index inferring numeric dtype from ndarray[object] #42870

merged 2 commits into from
Aug 8, 2021

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses labels Aug 4, 2021
@jreback jreback mentioned this pull request Aug 4, 2021
Closed
jreback
jreback reviewed Aug 4, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it. any perf implications?

@jreback jreback added this to the 1.4 milestone Aug 4, 2021
@jbrockmendel
Copy link
Member Author

any perf implications?

haven't run any asvs, but i expect we'll pick up a bit in the constructor in the affected corner cases

@jreback jreback merged commit 126a19d into pandas-dev:master Aug 8, 2021
@jbrockmendel jbrockmendel deleted the depr-index-infer-numeric branch August 9, 2021 01:49
@jorisvandenbossche
Copy link
Member

Didn't check how it's related, but it seems it caused a 4x slowdown specifically in is_all_dates for MultiIndex and IntervalIndex:

https://pandas.pydata.org/speed/pandas/#index_cached_properties.IndexCache.time_is_all_dates?python=3.8&Cython=0.29.21&p-index_type='IntervalIndex'&p-index_type='MultiIndex'&commits=126a19d0

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@jbrockmendel @feefladder
DEPR: Index inferring numeric dtype from ndarray[object] (pandas-dev#…
8e01a8e 
…42870)
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 10, 2022
Closed
3 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 8, 2022
Closed
3 tasks
sebp added a commit to sebp/scikit-survival that referenced this pull request Apr 10, 2023
@sebp
TESTS: Filter deprecation warning about inferring dtype
55d4584 
See pandas-dev/pandas#42870
@gdementen gdementen mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

API: numeric inference in Series constructor
3 participants
@jbrockmendel @jorisvandenbossche @jreback