FIX disallow MultiIndex in Series constructor GH4187 #4190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyone have an opinion on this (whether If anyone says "yes", I'll update. |
|
@hayd do it internally (e.g. don't use new) (you can just do a_multiindex.to_series() in init) |
|
I hate so I can just more this same couple of lines into the init? |
|
sorry....leave it there for now....that's ok (when refactor series will fix it) |
|
@jreback so should I change it to m..to_series() or shall we merge as NotImplemented (should fix this before 0.12, noone wants a segfault...). |
|
just leave as not implemented |
hayd
added a commit
that referenced
this pull request
Jul 13, 2013
FIX disallow MultiIndex in Series constructor GH4187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4187 (at least the segfault part).
Constructing Series with a MultiIndex raises NotImplementedError, the option (to implement this) is to return
.to_series()?