BUG/API: Index.__new__ match Series datetime inference behavior #40451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli any idea whats going on with the docstring validation script test? |
jorisvandenbossche
requested changes
Mar 16, 2021
| # mixed str/datetime | ||
| data = ["2012-12-31", datetime(2013, 1, 1), datetime(2013, 1, 2)] | ||
| result = Index(data) | ||
| expected = DatetimeIndex([Timestamp(x) for x in data]) |
There was a problem hiding this comment.
I don't find this an improvement (IMO we shouldn't infer strings just because timestamps are present), so if we want to (eventually) achieve consistency, I would rather deprecate this in the Series constructor.
jbrockmendel
added
API - Consistency
|
mothballing to clear the queue |
jbrockmendel
added
the
Mothballed
jbrockmendel
removed
the
Mothballed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us slightly more aggressive in casting to dt64 in
Index.__new__(see the added test_index_new test, it contains all of the cases that are reached in the existing tests where the current behavior differs from the PR behavior)Technically an API change, but I think its worth it to match the Series behavior.
Found+fixed a
pd.arraybug along the way.