Skip to content

TYP: incorrect annotations in internals.construction #40061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2021
Merged

TYP: incorrect annotations in internals.construction #40061

merged 2 commits into from
Feb 27, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback requested changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any perf difference? (e.g. wrapping with Index / ensure_index) a few times

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Feb 26, 2021
@jreback jreback added this to the 1.3 milestone Feb 26, 2021
@jreback
Copy link
Contributor

jreback commented Feb 26, 2021

cc @simonjayhawkins if you have a chance to look

@jbrockmendel
Copy link
Member Author

any perf difference? (e.g. wrapping with Index / ensure_index) a few times

i dont think so; the Index wrapping would have to happen eventually anyway. if anything, early consistent wrapping should make it easier to avoid re-checking later

@jreback jreback merged commit 9bdeee6 into pandas-dev:master Feb 27, 2021
@jbrockmendel jbrockmendel deleted the prelims branch February 27, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback