Skip to content

Remove numpy pin from environment.yml on 1.2.x #39998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
dependencies:
# required
- numpy>=1.16.5, <1.20 # gh-39513
- numpy>=1.16.5
- python=3
- python-dateutil>=2.7.3
- pytz
Expand Down
7 changes: 1 addition & 6 deletions pandas/tests/arrays/string_/test_string.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@

@pytest.fixture(
params=[
# pandas\tests\arrays\string_\test_string.py:16: error: List item 1 has
# incompatible type "ParameterSet"; expected
# "Sequence[Collection[object]]" [list-item]
"string",
pytest.param(
"arrow_string", marks=skip_if_no_pyarrow
), # type:ignore[list-item]
pytest.param("arrow_string", marks=skip_if_no_pyarrow),
]
)
def dtype(request):
Expand Down
6 changes: 2 additions & 4 deletions pandas/tests/window/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ def ignore_na(request):

@pytest.fixture(
params=[
pytest.param(
"numba", marks=td.skip_if_no("numba", "0.46.0")
), # type: ignore[list-item]
pytest.param("numba", marks=td.skip_if_no("numba", "0.46.0")),
"cython",
]
)
Expand Down Expand Up @@ -318,7 +316,7 @@ def halflife_with_times(request):
"float64",
"m8[ns]",
"M8[ns]",
pytest.param( # type: ignore[list-item]
pytest.param(
"datetime64[ns, UTC]",
marks=pytest.mark.skip(
"direct creation of extension dtype datetime64[ns, UTC] "
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is auto-generated from environment.yml, do not modify.
# See that file for comments about the need/usage of each dependency.

numpy>=1.16.5, <1.20
numpy>=1.16.5
python-dateutil>=2.7.3
pytz
asv
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ strict_equality = True
warn_redundant_casts = True
warn_unused_ignores = True
show_error_codes = True
no_site_packages = True

[mypy-pandas.tests.*]
check_untyped_defs=False
Expand Down