BENCH: skip slowest tzlocal asvs #39995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 24, 2021
| @@ -30,6 +30,10 @@ def setup(self, size, tz): | |||
| dti = pd.date_range("2016-01-01", periods=10, tz=tz).repeat(size // 10) | |||
| self.i8data = dti.asi8 | |||
|
|
|||
| if size == 10 ** 6 and tz is _tzs[-1]: | |||
There was a problem hiding this comment.
this seems a bit fragile, so 2 recommendations:
- let's skip tzlocal() entirely from benchmarks
- you can define a tzlocal import that we cache (might be complicated)
There was a problem hiding this comment.
updated to use 2.
if we ever get to cython 3.0 i think i'll be able to implement a tzlocal-equivalent in cython and this may cease to be an issue
jreback
requested changes
Feb 25, 2021
jreback
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running with
-b tslibsin master takes 141 minutes. This cuts it down to 36 minutes