CLN remove 'import pandas as pd' from pandas/core/generic.py #39152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jan 13, 2021
Comment on lines
+5307
to
+5310
| if isinstance(self, ABCSeries): | ||
| func = self._constructor | ||
| else: | ||
| func = self._constructor_sliced |
There was a problem hiding this comment.
Or is it better to import Series within this function so as to avoid an if-else block?
There was a problem hiding this comment.
yeah you can just import Series here
There was a problem hiding this comment.
the only reason you woul want this is to handle a subclass
|
nice |
|
thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will do the rest (excluding
pandas/tests) and add a check if this is the kind of thing we want