Skip to content

Update 10min.rst #38462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2020
Merged

Update 10min.rst #38462

merged 3 commits into from
Dec 14, 2020

Conversation

aflah02
Copy link
Contributor

@aflah02 aflah02 commented Dec 14, 2020

Added Links for Matplotlib Close along with a line explaining what it does.
I had faced difficulty when I read it for the first time and had to google search what close does

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@aflah02
Update 10min.rst
3a93fd3 
Added Links for Matplotlib Close along with a line explaining what it does
@aflah02
Copy link
Contributor Author

aflah02 commented Dec 14, 2020 •
edited
Loading

Hey!
Can someone explain what went wrong. This is the first time I used Sphinx directly but it seems to fail and I can't understand why

@aflah02
Copy link
Contributor Author

aflah02 commented Dec 14, 2020

@jbrockmendel
Hey
I saw your contributions and commits on the top page
I want some help here can you tell me what's going wrong and causing all this fail?

@jbrockmendel
Copy link
Member

Near the bottom of the page there is a red x for the "pre-commit" CI check. click on the "details" link to see the logs for the failed check. There is a line that the code-check wants to see changed, I think it just wants some whitespace removed.

@aflah02
Copy link
Contributor Author

aflah02 commented Dec 14, 2020 •
edited
Loading

Thank You @jbrockmendel

@aflah02
Update 10min.rst
0588f34 
Removed whitespace in the newly added line which was causing pre-commit / pre-commit (pull_request) to fail
@aflah02
Update 10min.rst
22ab5ee 
Removed whitespace from line 723 to try to fix Commit Check Fail
@aflah02
Copy link
Contributor Author

aflah02 commented Dec 14, 2020

@jbrockmendel
Hey I'd like to apologize in case my message was aggressive to say the least. Someone pointed it out to me and I am just starting but that is no excuse so I will try my best to keep this in mind in the future.
Thank You for all the help though

@jbrockmendel
Copy link
Member

Looks like the code check passed this time around. Good job. Someone more familiar with the docs will come along to review this before too long.

@jreback jreback added the Docs label Dec 14, 2020
@jreback jreback added this to the 1.3 milestone Dec 14, 2020
@jreback jreback merged commit e91cbd7 into pandas-dev:master Dec 14, 2020
@jreback
Copy link
Contributor

jreback commented Dec 14, 2020

thanks @aflah02

@aflah02
Copy link
Contributor Author

aflah02 commented Dec 15, 2020

@jreback You're Welcome

@aflah02 aflah02 deleted the docupdate branch December 15, 2020 04:31
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@aflah02 @luckyvs1
Update 10min.rst (pandas-dev#38462)
6965a44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aflah02 @jbrockmendel @jreback