Skip to content

Added test_set_index_dtypes_on_empty_DataFrames to check dtypes after… #38432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

IngErnestoAlvarez
Copy link

… using set_index on a DataFrame with empty Series that have dtype

  • closes BUG: set_index screws up the dtypes on empty DataFrames #38419
  • tests added / passed test_set_index_dtypes_on_empty_DataFrames
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry. Added a test to check that dtypes don't change after using set_index on a DataFrame with empty Series

… using set_index on a DataFrame with empty Series that have dtype
@pep8speaks
Copy link

pep8speaks commented Dec 12, 2020

Hello @IngErnestoAlvarez! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-12 21:35:33 UTC

@arw2019
Copy link
Member

arw2019 commented Dec 12, 2020

@IngErnestoAlvarez sorry to do this but closing as we already have a PR for this issue which was submitted first.

Thanks so much for opening the PR in the first place. We would of course love to have you contribute to resolve other tickets! Issues filed under the Contributions Welcome are a good place to look, and let us know if you need help at any point!

@arw2019 arw2019 closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: set_index screws up the dtypes on empty DataFrames
3 participants