REF: de-duplicate ndarray[datetimelike] wrapping #38129
Conversation
There was a problem hiding this comment.
Personally, I find the "maybe" in the name useful here, as in my head, our "maybe" function maybe do something with the input, but otherwise return it not modified (I don't know if we consistently follow that logic though, for all our maybe_ functions). While "wrap_datetimelike" sounds as it always wraps a datetimelike (maybe_wrap_datetimelike?)
|
wrap_if_datetimelike? |
pandas/core/construction.py
Outdated
| @@ -402,6 +402,24 @@ def extract_array(obj: object, extract_numpy: bool = False) -> Union[Any, ArrayL | |||
| return obj | |||
|
|
|||
|
|
|||
| def wrap_if_datetimelike(arr): | |||
There was a problem hiding this comment.
agree with joris that maybe_* is pretty much a convention and would go with that nomenclature.
There was a problem hiding this comment.
maybe_do_x usually means "try to do x and fallback on failure". i think wrap_if_datetimelike is more precise on this point.
There was a problem hiding this comment.
ok how about
ensure_datetimelike_index then
pandas/core/construction.py
Outdated
| @@ -402,6 +402,24 @@ def extract_array(obj: object, extract_numpy: bool = False) -> Union[Any, ArrayL | |||
| return obj | |||
|
|
|||
|
|
|||
| def wrap_if_datetimelike(arr): | |||
There was a problem hiding this comment.
can you type the arg (and return dtype)
There was a problem hiding this comment.
not really, its unrestricted
There was a problem hiding this comment.
aren't these always TDI/DTI on the return type? (sure input is just ArrayLike)
There was a problem hiding this comment.
no, we call it on arbitrary inputs in ops.array_ops
There was a problem hiding this comment.
ok then i am misunderstanding how this is used and its definetly maybe_wrap_if_datetimelike, its either ensure or maybe, really shouldn't be any other choices.
jreback
added
Refactor
|
thanks, type if possible in the future |
No description provided.