Skip to content

CLN: tests/window/* #37926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 18, 2020
Merged

CLN: tests/window/* #37926

merged 8 commits into from
Nov 18, 2020

Conversation

mroeschke
Copy link
Member

  • Renamed test_window.py to test_win_type.py
  • Added 'count' to arithmetic_win_operators
  • Reused fixtures
  • Used more pytest idioms in test_moments_consistency_expanding.py

@pep8speaks
Copy link

pep8speaks commented Nov 18, 2020 •
edited
Loading

Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-18 17:41:06 UTC

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Nov 18, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 18, 2020
@mroeschke mroeschke changed the title CLN: tests/windows/* CLN: tests/window/* Nov 18, 2020
simonjayhawkins
simonjayhawkins reviewed Nov 18, 2020
View reviewed changes
pandas/tests/window/moments/test_moments_consistency_expanding.py Outdated
series=series,
frame=frame,
nan_locs=nan_locs,
@pytest.mark.parametrize("constructor", [Series, DataFrame])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a frame_or_series fixture that could be used here.

jreback
jreback approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ex @simonjayhawkins comment

@jreback jreback merged commit 085a22d into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

thanks @mroeschke

@mroeschke mroeschke deleted the cln/window_tests branch November 18, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @pep8speaks @jreback @simonjayhawkins