TST/REF: collect/parametrize tests from tests.generic #37730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Nov 10, 2020
| @@ -41,49 +40,76 @@ def test_convert_dti_to_series(self): | |||
| ), | |||
| name="B", | |||
| ) | |||
| assert expected.dtype == idx.dtype | |||
There was a problem hiding this comment.
I'm probably a little rusty on review :-) but is using assert in a fixture a common idiom?
There was a problem hiding this comment.
its probably not super-encouraged but i dont think its an anti-pattern
WillAyd
added
Refactor
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of these its just breaking up big tests and giving them meaningful names.