TYP: use typing.final in indexes.base #37527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 31, 2020
pandas/core/indexes/base.py
Outdated
| @@ -100,7 +100,12 @@ | |||
| ) | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from typing import final | |||
There was a problem hiding this comment.
can you instead define this in _typing?
There was a problem hiding this comment.
huh, i thought i couldnt bc of the static-checking thing, but it looks like i can. will update
jreback
approved these changes
Oct 31, 2020
|
lgtm. @simonjayhawkins if comments. |
|
Thanks @jbrockmendel lgtm |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @simonjayhawkins this imports final conditionally following how you did it with Literal