Skip to content

ENH: enhance set_option syntax #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2013
Merged

ENH: enhance set_option syntax #3677

merged 1 commit into from
May 30, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 21, 2013

closes #3667.

@jreback
Copy link
Contributor

jreback commented May 22, 2013

who says my schemes are evil :)
well...maybe a little

@cpcloud
Copy link
Member Author

cpcloud commented May 22, 2013

k removed it sorry for the unnecessary stuff

@jreback
Copy link
Contributor

jreback commented May 30, 2013

@y-p this ok?

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

rebased

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

a7d404ca9dc1a2869b4c49bb46e5c5385452955f is the latest

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

the original reason if you're interested was because ast.literal_eval was exactly what was needed: a safe eval that only evaluates basic python objects

@ghost
Copy link

ghost commented May 30, 2013

The commit subject for a7d404c says it's concerned with the test suite, which Is why review is confusing.
with squashing, look fine to me.

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

oh sorry ok i will be more careful with my commit messages

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

squashed

@cpcloud
Copy link
Member Author

cpcloud commented May 30, 2013

@jreback this has been squashed and is ready to go.

jreback added a commit that referenced this pull request May 30, 2013
@jreback jreback merged commit 09df295 into pandas-dev:master May 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: option setting syntax enhancements
2 participants