-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Fix typo of =!
to !=
in docstring
#36077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes GH36075.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daytonb lgtm pending green
Thanks @daytonb ! |
Thanks! It's been a pleasure. Thanks for the quick merge. |
This fixes GH36075.
So this change actually breaks building docs, at least using sphinx. Leads to an error
whereas simply swapping them back fixes the problem. Any idea what might be going on here? |
Is no one else gets to it before me I could look into it, but probably not
until tomorrow.
…On Fri, Apr 2, 2021 at 7:34 PM Sami Jawhar ***@***.***> wrote:
So this change actually breaks building docs, at least using sphinx. Leads
to an error
/usr/local/lib/python3.8/site-packages/docutils/nodes.py", line 567, in __getitem__
return self.attributes[key]
KeyError: 'reftarget'
whereas simply swapping them back fixes the problem. Any idea what might
be going on here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36077 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJTWI3UNDN2GEQOTMUPOK3TGZH7HANCNFSM4QTOIJ3A>
.
|
@sjawhar, can you give me the steps you ran to reproduce this issue? It seams unlikely that my text change could lead to the error you posted. Also, when I my docstring change is already part of the current (v1.2.3) release and the documentation is rendered properly online, all of which seems to indicate that this docstring change isn't the cause of the issue you're reporting. If you can give me some steps to reproduce, I'd be happy to try to figure out what's going on. |
This fixes GH36075.
I'm marking the following list items as not-applicable because I'm simply swapping two characters in a docstring that had been in the incorrect order.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff