Fix numpydev CI failure #35496
Closed
Fix numpydev CI failure #35496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending green |
|
Adding to 1.1.1 as I think should backport - @TomAugspurger or @simonjayhawkins good to merge? |
|
Yep to backport, whenever you're ready.
…On Fri, Jul 31, 2020 at 2:46 PM William Ayd ***@***.***> wrote:
Adding to 1.1.1 as I think should backport - @TomAugspurger
<https://github.com/TomAugspurger> or @simonjayhawkins
<https://github.com/simonjayhawkins> good to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35496 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIVJQ6OC3IR5J6NEIH3R6MNSVANCNFSM4PQXJ6QQ>
.
|
aren't the same tests failing or am I missing something. we only have Travis running on backport so could wait to backport till after the 2 PRs activating azure and github actions are merged. |
|
@simonjayhawkins whoops good point. Using the github app misread the checks. Will take a look in a bit |
simonjayhawkins
added
CI
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff