Skip to content

CLN/TYP: Groupby agg methods #34200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2020
Merged

CLN/TYP: Groupby agg methods #34200

merged 1 commit into from
May 17, 2020

Conversation

topper-123
Copy link
Contributor

Same as #34178. I had some trouble rebasing that PR, so just made a new PR instead.

This takes care of the comment in #34178 about staticmethod.

@topper-123 topper-123 mentioned this pull request May 15, 2020
Closed
@topper-123 topper-123 force-pushed the groupby_agg_methods_II branch from 5f27fb7 to 8af8b7a Compare May 15, 2020 21:24
@topper-123 topper-123 force-pushed the groupby_agg_methods_II branch from 8af8b7a to 1aee75e Compare May 15, 2020 21:48
@jreback jreback added Groupby Typing type annotations, mypy/pyright type checking labels May 17, 2020
@jreback jreback added this to the 1.1 milestone May 17, 2020
@jreback jreback merged commit 0f52751 into pandas-dev:master May 17, 2020
@jreback
Copy link
Contributor

jreback commented May 17, 2020

thanks @topper-123
very nice.

@topper-123 topper-123 deleted the groupby_agg_methods_II branch August 8, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@topper-123 @jreback