Skip to content

TYP: F used in decorators to _typing #33456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

simonjayhawkins
Copy link
Member

xref #27404

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Apr 10, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.1 milestone Apr 10, 2020

FuncType = Callable[..., Any]
F = TypeVar("F", bound=FuncType)
from pandas._typing import F
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side issue i think we should isort so _typing imports right after typing

@jreback jreback merged commit 12b0d45 into pandas-dev:master Apr 10, 2020
@jreback
Copy link
Contributor

jreback commented Apr 10, 2020

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the misc-decorators branch April 10, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants