BUG/REF: unstack with EA dtypes #33356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,10 +10,22 @@ class BaseCastingTests(BaseExtensionTests): | |||
| """Casting to and from ExtensionDtypes""" | |||
|
|
|||
| def test_astype_object_series(self, all_data): | |||
| ser = pd.Series({"A": all_data}) | |||
| ser = pd.Series(all_data, name="A") | |||
with "-b reshape" no change |
jbrockmendel
added
Bug
Reshaping
|
thanks nice de-duplicating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ser.unstack(args)should behave likeser.to_frame().unstack(args).droplevel(level=0, axis=1). This fails on master, is fixed by this PR.reshape._unstack_extension_seriescurrently re-implements logic that is inExtensionBlock._unstack. This de-duplicates by dispatching.DataFrame._can_fast_transposeto avoid that.test_astype_object_serieshas what looks like a typo that is making us test not-the-intended-thing; @TomAugspurger can you confirm im reading this right?test_astype_object_framecurrently raise, are commented out for exposition, should be fixed in a separate PR.