BUG: fix unsafe dtype conversion in Series #3292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wesm this should fix it. FYI once series inherits from NDFrame this magic is completely gone (as its a simple block change, which is easy to do even inplace) |
allow boolean indexing of series w/o changing the dtype
with a list of the rhs if we can preserver the dtype
of the input, if we can't upcast, but can only do this
in cases where we won't change the itemsize
|
@wesm this new version is cleaner |
|
Shoehorning |
wesm
added a commit
that referenced
this pull request
Apr 9, 2013
BUG: fix unsafe dtype conversion in Series
|
@wesm already set to clean up in 0.12. where is moved to core/generic.py and a dtype change is simple because just make a new block...coming soon |
|
@y-p sorry....:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes assignment to smaller itemsizes on dtype upcasting