CLN: simplify MultiIndex._shallow_copy #32772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
clean_multiindex_shallow_copy
branch
from
713db7c to
fb4f8ec
Compare
topper-123
commented
Mar 17, 2020
| @@ -990,15 +990,11 @@ def _constructor(self): | |||
| def _shallow_copy(self, values=None, **kwargs): | |||
| if values is not None: | |||
| names = kwargs.pop("names", kwargs.pop("name", self.names)) | |||
| # discards freq | |||
| kwargs.pop("freq", None) | |||
There was a problem hiding this comment.
Dropping this silently makes no sense, freq isn't accepted by any MultiIndex constructor. Just let it be passed in and raise a TypeError if encountered.
|
LGTM |
| @@ -990,15 +990,11 @@ def _constructor(self): | |||
| def _shallow_copy(self, values=None, **kwargs): | |||
| if values is not None: | |||
| names = kwargs.pop("names", kwargs.pop("name", self.names)) | |||
There was a problem hiding this comment.
do we need to worry about both name and names being passed?
There was a problem hiding this comment.
MultiIndex.from_tuples only accepts names, and Mi uses name in some locations, so yes (but it a part of the ickyness of MultiIndex, so should ideally be refactored away).
|
thanks @topper-123 |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor simplification of
MultiIndex._shallow_copy.