TST: Parametrize in pandas/tests/internals/test_internals.py #32687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Mar 13, 2020
WillAyd
added
Clean
Testing
| tm.assert_frame_equal(DataFrame(mgr), DataFrame(mgr2)) | ||
|
|
||
| mgr = create_mgr("a: f8; a: i8") | ||
| @pytest.mark.parametrize("mgr_string", ["a,a,a:f8", "a: f8; a: i8"]) |
There was a problem hiding this comment.
are the spaces meaningful?
| "mgr_string, dtype", | ||
| [ | ||
| ("a: category", "i8"), | ||
| ("a: category; b: category", "i8"), |
There was a problem hiding this comment.
heads up: this case is incorrect, as is the one on L558. xref #32519.
|
can you rebase |
|
##[error]./pandas/tests/internals/test_internals.py:558:5:F811:redefinition of unused 'test_interleave' from line 549 |
jreback
approved these changes
Mar 19, 2020
|
@MomIsBestFriend can you rebase and ping on green |
|
Restarting azure as I am not sure why it failed. |
|
ping @jbrockmendel, the CI is green. |
|
thanks @MomIsBestFriend |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
…dev#32687) * TST: Parametrize in pandas/tests/internals/test_internals.py * Addressed lint issues * Addressing lint issues Co-authored-by: MomIsBestFriend <>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
…dev#32687) * TST: Parametrize in pandas/tests/internals/test_internals.py * Addressed lint issues * Addressing lint issues Co-authored-by: MomIsBestFriend <>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 25, 2020
…dev#32687) * TST: Parametrize in pandas/tests/internals/test_internals.py * Addressed lint issues * Addressing lint issues Co-authored-by: MomIsBestFriend <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff