-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: remove SingleBlockManager.get_values #32522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@datapythonista do you think it would be viable to make the docbuild output less verbose to make it easier to see what is causing a failure? |
Not sure if it's possible to have more control, but may be we can call it with
I think it can make sense, I don't think there is anything in the output that I find that useful (surely not all the "reading" and "writing" for the progress). But @jorisvandenbossche should know better if that makes sense. |
If we want that, someone should investigate if all errors we want to see still show up (eg the output of ipython directive might be put on stdout). But @jbrockmendel, for this specific PR, what was failing in the doc build? (I only see a failure to checkout in the pipeline) |
I never found out. AFAICT it was unrelated and eventually re-pushing solved it. |
As far as I looked, the doc build actually didn't fail. It was the checkout phase of the the action that failed |
Looking in the logs I see the same thing, maybe past-me intended to ask about this on a different PR. |
It is only used in one place, and its behavior doesn't match
self.blocks[0].get_values()
, which is counter-intuitive.