Skip to content

CLN: remove SingleBlockManager.get_values #32522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

jbrockmendel
Copy link
Member

It is only used in one place, and its behavior doesn't match self.blocks[0].get_values(), which is counter-intuitive.

@jbrockmendel
Copy link
Member Author

@datapythonista do you think it would be viable to make the docbuild output less verbose to make it easier to see what is causing a failure?

@datapythonista
Copy link
Member

@datapythonista do you think it would be viable to make the docbuild output less verbose to make it easier to see what is causing a failure?

Not sure if it's possible to have more control, but may be we can call it with -q. Those are the options I see:

console output options:
  -v                increase verbosity (can be repeated)
  -q                no output on stdout, just warnings on stderr
  -Q                no output at all, not even warnings

I think it can make sense, I don't think there is anything in the output that I find that useful (surely not all the "reading" and "writing" for the progress). But @jorisvandenbossche should know better if that makes sense.

@jorisvandenbossche
Copy link
Member

If we want that, someone should investigate if all errors we want to see still show up (eg the output of ipython directive might be put on stdout).

But @jbrockmendel, for this specific PR, what was failing in the doc build? (I only see a failure to checkout in the pipeline)

@jbrockmendel
Copy link
Member Author

for this specific PR, what was failing in the doc build?

I never found out. AFAICT it was unrelated and eventually re-pushing solved it.

@jreback jreback added Clean Internals Related to non-user accessible pandas implementation labels Mar 11, 2020
@jreback jreback added this to the 1.1 milestone Mar 11, 2020
@jreback jreback merged commit 8e74325 into pandas-dev:master Mar 11, 2020
@jbrockmendel jbrockmendel deleted the mgr-get_values branch March 11, 2020 02:23
@jorisvandenbossche
Copy link
Member

But @jbrockmendel, for this specific PR, what was failing in the doc build? (I only see a failure to checkout in the pipeline)

As far as I looked, the doc build actually didn't fail. It was the checkout phase of the the action that failed

@jbrockmendel
Copy link
Member Author

As far as I looked, the doc build actually didn't fail. It was the checkout phase of the the action that failed

Looking in the logs I see the same thing, maybe past-me intended to ask about this on a different PR.

SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants