Skip to content

DEPS: Removing snappy from local/docs dependencies #32454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DEPS: Removing snappy from local/docs dependencies #32454

wants to merge 1 commit into from

Conversation

datapythonista
Copy link
Member

The docs build should fail if snappy is required to build the docs, and should point out where it's being used. If it's not failed, I think this can be merged and we can remove snappy from the local and docs dependencies.

@datapythonista datapythonista added CI Continuous Integration Dependencies Required and optional dependencies labels Mar 5, 2020
@jorisvandenbossche
Copy link
Member

The parquet examples require snappy (so "the docs build should fail if snappy is required to build the docs" -> this is happening).

Snappy is not a hard requirement, but it would need some code edits to make the examples pass (specify a compression option manually). Personally I would just keep snappy in the env.

@jorisvandenbossche
Copy link
Member

(sorry, missed the discussion in the issue)

@datapythonista
Copy link
Member Author

Removing snappy from the local dependencies make the docs build fail (when calling to_parquet by default snappy is used, and we have that in the docs, including to show benchmarks). Closing this, as the main point was to test that, More details, and the discussion about options in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants