Skip to content

CI: silence numpy-dev failures #32025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2020
Merged

CI: silence numpy-dev failures #32025

merged 3 commits into from
Feb 15, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Feb 15, 2020 •
edited
Loading

xref #31992

@simonjayhawkins simonjayhawkins added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Feb 15, 2020
jreback
jreback requested changes Feb 15, 2020
View reviewed changes
pandas/tests/frame/test_cumulative.py
@@ -7,6 +7,9 @@
"""

import numpy as np
import pytest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use the _test_decorator version of this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you referring to pandas/util/_test_decorators.py?

we have nothing for np-dev there (just skip_if_np_lt) . also those are skips and don't we want an xfail?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok instead of importing from here (this is not meant for this)
import from pd. where all of the lives (you will to add the import in pandas/init.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. we currently have a mixture of imports for _np_version_under1p* and wasn't sure which was the preferred.

jreback
jreback requested changes Feb 15, 2020
View reviewed changes
pandas/tests/frame/test_cumulative.py
@@ -7,6 +7,9 @@
"""

import numpy as np
import pytest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok instead of importing from here (this is not meant for this)
import from pd. where all of the lives (you will to add the import in pandas/init.py

@simonjayhawkins
Copy link
Member Author

ok. this is starting to look promising.

not marking the issue as closed since only silencing here (hence using xfails instead of skips). so fixing the issue is outstanding.

was not able to reproduce the failures locally so didn't attempt to fix.

will flag as 1.0.2 and backport in order to keep CI there green too.

@simonjayhawkins simonjayhawkins added this to the 1.0.2 milestone Feb 15, 2020
@simonjayhawkins
Copy link
Member Author

@jreback ping green

@simonjayhawkins
Copy link
Member Author

i'll merge in about 10mins if no objections. can always revert or follow-on if issues.

@simonjayhawkins simonjayhawkins merged commit 53ece70 into pandas-dev:master Feb 15, 2020
@simonjayhawkins
Copy link
Member Author

looks like these tests are flakey. will need to skip instead if xfail.

@jreback
Copy link
Contributor

jreback commented Feb 15, 2020

xfail is ok but add strict=False

much better than skips

@simonjayhawkins
Copy link
Member Author

xfail is ok but add strict=False

much better than skips

sounds good.

@simonjayhawkins simonjayhawkins mentioned this pull request Feb 15, 2020
Merged
@simonjayhawkins simonjayhawkins deleted the troubleshoot-ci branch February 15, 2020 20:13
@dsaxton dsaxton mentioned this pull request Feb 16, 2020
Closed
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Feb 17, 2020
@simonjayhawkins
CI: silence numpy-dev failures (pandas-dev#32025)
a7aa063
TomAugspurger pushed a commit that referenced this pull request Feb 17, 2020
@simonjayhawkins
Backport PR #32025 and #32031 silence numpy-dev failures (#32057)
ad54c65 
* CI: silence numpy-dev failures (#32025)

* CI: change np-dev xfails to not strict (#32031)

* test_transform_transformation_func not backported
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@simonjayhawkins @roberthdevries
CI: silence numpy-dev failures (pandas-dev#32025)
b3a7f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @WillAyd